Move Dart licenses into a separate golden file #43289
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This PR will need to be coordinated with an update to the Dart->engine roller configuration so that new rolls will reference the |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Just reviewed tools/licenses/lib/main.dart
|
This is waiting on the branch cut to be completed. |
jason-simmons
force-pushed
the
licenses_dart_separate
branch
3 times, most recently
from
1681aa0 to
d0fd86a
Compare
This will avoid conflicts between Dart rolls and rolls of other third party components such as ANGLE.
jason-simmons
force-pushed
the
licenses_dart_separate
branch
from
d0fd86a to
a1a2436
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…130758) flutter/engine@15c15fd...09689d3 2023-07-17 [email protected] [Windows] Remove accessibility bridge helpers from the engine (flutter/engine#43710) 2023-07-17 [email protected] Move Dart licenses into a separate golden file (flutter/engine#43289) 2023-07-17 [email protected] Roll Skia from f29d58569c67 to f2a4222bb72e (1 revision) (flutter/engine#43746) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This will avoid conflicts between Dart rolls and rolls of other third party components such as ANGLE.
…lutter#130758) flutter/engine@15c15fd...09689d3 2023-07-17 [email protected] [Windows] Remove accessibility bridge helpers from the engine (flutter/engine#43710) 2023-07-17 [email protected] Move Dart licenses into a separate golden file (flutter/engine#43289) 2023-07-17 [email protected] Roll Skia from f29d58569c67 to f2a4222bb72e (1 revision) (flutter/engine#43746) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
This will avoid conflicts between Dart rolls and rolls of other third party components such as ANGLE.