This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix CPU Porter-Duff blends #43217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Jun 26, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
So we'll have goldens tracking these?
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Contributor
|
(Looks like yes, SGTM) |
Member
Author
|
Yeah I got the CPU blends roped into the blend goldens as part of #43117. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 27, 2023
…129599) flutter/engine@715eff2...f320b8c 2023-06-27 [email protected] [web] Removes patchCanvasKitModule. (flutter/engine#42941) 2023-06-26 [email protected] Roll ANGLE from cafbf6e2660f to cba77bceb26c (1 revision) (flutter/engine#43222) 2023-06-26 [email protected] [Impeller] Fix CPU Porter-Duff blends (flutter/engine#43217) 2023-06-26 [email protected] Roll Skia from c1effc01211e to 370132bcadb1 (2 revisions) (flutter/engine#43221) 2023-06-26 [email protected] Roll ANGLE from 4a4b13cc6931 to cafbf6e2660f (2 revisions) (flutter/engine#43219) 2023-06-26 [email protected] Roll Skia from 4ae209493390 to c1effc01211e (4 revisions) (flutter/engine#43218) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Part of flutter/flutter#128606. * Fix all of the Porter-Duff blends (virtually all of the blends were wrong). Still working on getting all of the advanced/color blends fixed up. * Fill in missing ops for arithmetic types/remove Vector4 conversions. * Remove the original GeometryTest in favor of the much clearer goldens. Once we have all of the CPU blends matching up properly with the GPU blends, we can think about constructing a more intentional test that covers a select number of important cases with accompanying explanation. Top rectangles = GPU blends Bottom rectangles = CPU blends
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#128606.
Top rectangles = GPU blends
Bottom rectangles = CPU blends
Before:
Screen.Recording.2023-06-22.at.4.45.25.PM.mov
After:
Screen.Recording.2023-06-26.at.1.55.55.PM.mov