This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] use default precision specifiers. #43183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 26, 2023
| "variants": { | ||
| "Main": { | ||
| "fp16_arithmetic": 100, | ||
| "fp16_arithmetic": 0, |
Member
There was a problem hiding this comment.
I guess the compute shaders need this specification as well?
Contributor
Author
There was a problem hiding this comment.
all of the compute shaders are dealing with positional data so defaulting to mediump is probably a bad idea
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 26, 2023
…129569) flutter/engine@6358232...4032a9b 2023-06-26 [email protected] [Impeller] use default precision specifiers. (flutter/engine#43183) 2023-06-26 [email protected] Roll Fuchsia Mac SDK from GkEyRw1Q2qLZWxitD... to ytzCCSvHY1lHWEDM9... (flutter/engine#43200) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from GkEyRw1Q2qLZ to ytzCCSvHY1lH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Instead of adding precision mediump float to all shaders that import types.glsl, let vertex shaders be highp by default. Opt rrect blur into highp and all other fragment shaders into mediump. For reasons I don't understand, the default for fragment shaders is being treated as highp without any specifiers. Fixes flutter/flutter#128284
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding precision mediump float to all shaders that import types.glsl, let vertex shaders be highp by default. Opt rrect blur into highp and all other fragment shaders into mediump. For reasons I don't understand, the default for fragment shaders is being treated as highp without any specifiers.
Fixes flutter/flutter#128284