-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Uniquely label subpasses and root blit #43015
Conversation
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
auto label is removed for flutter/engine, pr: 43015, Failed to merge flutter/engine/43015 with Pull request could not be merged: Required status check "ci.yaml validation" is expected.. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…129331) flutter/engine@08aaa88...c6251a6 2023-06-22 [email protected] Remove process-local tempfs (flutter/engine#43056) 2023-06-22 [email protected] Roll Skia from 0185ce148be9 to 076e7c004d20 (2 revisions) (flutter/engine#43069) 2023-06-22 [email protected] Roll Skia from 96d6135e9ee8 to 0185ce148be9 (4 revisions) (flutter/engine#43068) 2023-06-22 [email protected] [Impeller] Uniquely label subpasses and root blit (flutter/engine#43015) 2023-06-22 [email protected] [Impeller] Add Rect::Project (flutter/engine#43026) 2023-06-21 [email protected] Roll Skia from 32e953e71266 to 96d6135e9ee8 (1 revision) (flutter/engine#43067) 2023-06-21 [email protected] Roll Fuchsia Mac SDK from ct6r5YjdG2xpZPhkT... to QtQznuUmHMTyORqxJ... (flutter/engine#43065) 2023-06-21 [email protected] Roll Fuchsia Linux SDK from 4mkuVtlGBaumKSe8x... to 7EZeNE4aGd29VfDly... (flutter/engine#43066) 2023-06-21 [email protected] Roll ANGLE from 3a3a3c655a96 to ac263582dda4 (60 revisions) (flutter/engine#43062) 2023-06-21 [email protected] Roll Skia from 7eeb94b1e778 to 32e953e71266 (17 revisions) (flutter/engine#43064) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 4mkuVtlGBaum to 7EZeNE4aGd29 fuchsia/sdk/core/mac-amd64 from ct6r5YjdG2xp to QtQznuUmHMTy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Makes subpasses easier to identify in frame captures.