This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[android]: Make Robolectric tests work with SDK 33 #42965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @chinmaygarde @stuartmorgan for reviewing. Thanks. |
Signed-off-by: utzcoz <[email protected]>
chinmaygarde
approved these changes
Jun 22, 2023
jason-simmons
approved these changes
Jun 22, 2023
reidbaker
approved these changes
Jun 22, 2023
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 22, 2023
…129382) flutter/engine@ed477de...7ff6a65 2023-06-22 [email protected] [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965) 2023-06-22 [email protected] Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Robolectric tests work with SDK 33. The Robolectric doesn't support create presentation window now, so this CL also adds a custom presentation shadow to hook showing state to make related tests work.
Pre-launch Checklist
///).