[Impeller] correct default PSO pixel format and sample count. #42902
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Holding off on landing this, I'd like to make sure that this and @gaaclarke 's patch roll in separately so we can have an independent accounting of performance impact (i'd expect the change from this to be minor overall though) |
|
Thanks for holding off. I'm poking around trying to get the roll going again so we can get measurements. Unfortunately I went from a roll with 1 commit to a roll with 17, hopefully nothing else affects the numbers in there. |
jonahwilliams
added
the
autosubmit
…129047) flutter/engine@7483c8a...7ffa135 2023-06-16 [email protected] Roll Skia from 01f3be45e0d6 to 64fa632d3b01 (3 revisions) (flutter/engine#42937) 2023-06-16 [email protected] [web] Fix for Safari autofill flickering bug (flutter/engine#42830) 2023-06-16 [email protected] [Impeller] correct default PSO pixel format and sample count. (flutter/engine#42902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Despite compiling an initial PSO variant for every shader, in practice these were completely useless as they had a sample count of 1 (instead of 4 for MSAA) and an invalid pixel format.
Correct the defaults so they may be usful.
Not enough to fix flutter/flutter#128963 , because we still have far too much state for Vulkan to handle