Make validation logs ERROR level #42825
Conversation
INFO logs do not show up in normal logging unless an extra flag is passed by the tool (and it is a different flag from the "-v" flag). This means bug reports that include logs about impeller are missing the validation errors, which makes them harder to triage and dedupe. Fixes flutter/flutter#128808
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Isn't this going to potentially print out anytime we use opengl as the fallback? Should this only be ERROR in debug builds?
It's only going to print out if |
|
(and knowing why we failed to choose vulkan may be valuable information anyway) |
dnfield
added
the
autosubmit
…lutter#128842) flutter/engine@727b441...2d8d5ec 2023-06-13 [email protected] Roll Skia from 6bdb0ef30cb6 to 6d5dc31d88e2 (7 revisions) (flutter/engine#42790) 2023-06-13 [email protected] Make validation logs ERROR level (flutter/engine#42825) 2023-06-13 [email protected] Roll Fuchsia Mac SDK from J-zU9HGYXYU5UWJO9... to Cld7-rm6ZmCOO8j-K... (flutter/engine#42824) 2023-06-13 [email protected] Manual roll ICU from 1eea59cabae0 to a2961dc659b4 (0 revision) (flutter/engine#42817) 2023-06-13 [email protected] Remove some trivial deprecated symbol usages in iOS Embedder (flutter/engine#42711) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from J-zU9HGYXYU5 to Cld7-rm6ZmCO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
INFO logs do not show up in normal logging unless an extra flag is passed by the tool (and it is a different flag from the "-v" flag).
This means bug reports that include logs about impeller are missing the validation errors, which makes them harder to triage and dedupe.
Fixes flutter/flutter#128808