Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@filmil
Copy link
Contributor

@filmil filmil commented Jun 13, 2023

Manual roll of ICU to a2961dc659b4ae847a9c6120718cc2517ee57d9erevision

Issue: flutter/flutter#128818

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@filmil filmil changed the title Update icu 13jun2023 Manual roll of ICU to a2961dc659b4ae847a9c6120718cc2517ee57d9erevision Jun 13, 2023
@filmil filmil force-pushed the update-icu-13jun2023 branch 2 times, most recently from 5e39b35 to 309aa65 Compare June 13, 2023 19:53
@filmil filmil force-pushed the update-icu-13jun2023 branch from 309aa65 to eb71f6b Compare June 13, 2023 20:19
@tamird tamird added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 13, 2023

auto label is removed for flutter/engine, pr: 42819, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@filmil
Copy link
Contributor Author

filmil commented Jun 13, 2023

Equivalent change landed at #42817, this can be closed.

@filmil filmil closed this Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants