This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Ensure vulkan offscreen pixelformat is the same as the onscreen format #42788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
approved these changes
Jun 12, 2023
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 42788, due to - The status or check suite Linux Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2023
…as the onscreen format (flutter/engine#42788)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 13, 2023
…128759) flutter/engine@d02b15e...aa1693f 2023-06-13 [email protected] Roll Dart SDK from 605fd026151b to 7bacb78a0db8 (1 revision) (flutter/engine#42795) 2023-06-13 [email protected] [Impeller] Ensure vulkan offscreen pixelformat is the same as the onscreen format (flutter/engine#42788) 2023-06-13 [email protected] Roll Fuchsia Linux SDK from pd1VfyK_WEW6tu8WI... to r0hMbc7UJwTJkxjbt... (flutter/engine#42786) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from pd1VfyK_WEW6 to r0hMbc7UJwTJ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#128604
THe problem was that we were selecting kB8G8R8A8UNormInt for the offscreen and kR8G8B8A8UNormInt for the onscreen, so the blit was swapping the color channels.