This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove some trivial deprecated symbol usages in iOS Embedder #42711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2023 14:23
Contributor
|
test-exempt: code refactor with no semantic change |
stuartmorgan-g
suggested changes
Jun 12, 2023
| length:screenshot.data->size()]; | ||
| NSString* format = [NSString stringWithCString:screenshot.format.c_str()]; | ||
| NSString* format = [NSString stringWithCString:screenshot.format.c_str() | ||
| encoding:NSUTF8StringEncoding]; |
Contributor
There was a problem hiding this comment.
stringWithUTF8String:
Contributor
Author
There was a problem hiding this comment.
Nice, also updated another places used stringWithCString:encoding:
|
|
||
| [center addObserver:self | ||
| selector:@selector(onAccessibilityStatusChanged:) | ||
| name:UIAccessibilityVoiceOverStatusChanged |
Contributor
There was a problem hiding this comment.
Don't we need to replace this with UIAccessibilityVoiceOverStatusDidChangeNotification instead of removing it?
Contributor
Author
There was a problem hiding this comment.
Oh, I mistakenly thought the below notification is UIAccessibilityVoiceOverStatusDidChangeNotification and said we have already implemented it in the issue. I updated the issue and fixed this.
cyanglaz
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 42711, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 14, 2023
Piinks
pushed a commit
to Piinks/flutter
that referenced
this pull request
Jun 14, 2023
…lutter#128842) flutter/engine@727b441...2d8d5ec 2023-06-13 [email protected] Roll Skia from 6bdb0ef30cb6 to 6d5dc31d88e2 (7 revisions) (flutter/engine#42790) 2023-06-13 [email protected] Make validation logs ERROR level (flutter/engine#42825) 2023-06-13 [email protected] Roll Fuchsia Mac SDK from J-zU9HGYXYU5UWJO9... to Cld7-rm6ZmCOO8j-K... (flutter/engine#42824) 2023-06-13 [email protected] Manual roll ICU from 1eea59cabae0 to a2961dc659b4 (0 revision) (flutter/engine#42817) 2023-06-13 [email protected] Remove some trivial deprecated symbol usages in iOS Embedder (flutter/engine#42711) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from J-zU9HGYXYU5 to Cld7-rm6ZmCO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringWithCString was deprecated in iOS 2.0
UIAccessibilityVoiceOverStatusChanged was deprecated in iOS 11.0
fixes: flutter/flutter#128732
flutter/flutter#128736
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.