[Impeller] Add CPU implementations for all color filters #42692
Conversation
| ASSERT_TRUE(OpenPlaygroundHere(callback)); | ||
| } | ||
|
|
||
| TEST_P(EntityTest, TTTBlendColor) { |
There was a problem hiding this comment.
What's replacing these tests?
See also flutter/flutter#128606. It's possible some of these tests are encoding bad behavior, but it seems veyr likely to me that if they are not encoding bad behavior they're missing cases where there's bad behavior.
There was a problem hiding this comment.
Sorry, I see below the new tests.
There was a problem hiding this comment.
Yeah I just moved this existing test into GeometryTest.ColorBlend. And yes, some of them are wrong -- we used to use these for absorbing the DrawPaints, which introduced bugs. Some blends are also missing from the test at the moment.
There was a problem hiding this comment.
The test also has too many cases and needs to be rewritten in general, or at least be annotated to state why each cases is useful and not redundant.
…128612) flutter/engine@071e1fb...488876e 2023-06-09 [email protected] Roll ANGLE from a185cb8c8924 to 3e4f4caebcb0 (2 revisions) (flutter/engine#42701) 2023-06-09 [email protected] [Impeller] Add CPU implementations for all color filters (flutter/engine#42692) 2023-06-09 [email protected] [Impeller] add explicit VMA flush to device memory writes. (flutter/engine#42685) 2023-06-09 [email protected] [Impeller] Makes validation layers flag work for android (flutter/engine#42625) 2023-06-09 [email protected] Platform channel for predictive back (flutter/engine#39208) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Part of flutter/flutter#127232.
Adds a CPU implementation for ColorMatrix and the color space conversions. Also changes the blend signature for consistency.
These will be necessary to make the mask blur fast path continue working in the presence of color filters. In general, we can use these to eliminate a needlessly expensive image-based color filter for the non-image color sources.