Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove master mirroring workflow. #42681

Merged
auto-submit merged 1 commit into from
Jun 23, 2023
Merged

Remove master mirroring workflow. #42681

auto-submit merged 1 commit into from
Jun 23, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jun 8, 2023

All the uses of master in the engine have been removed. We are removing mirroring in preparation to archive the master branch.

Bug: flutter/flutter#90476

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove master mirroring workflow.
3bc1160 
All the uses of master in the engine have been removed. We are removing
mirroring in preparation to archive the master branch.

Bug: flutter/flutter#90476
@godofredoc godofredoc requested a review from zanderso June 8, 2023 21:50
@zanderso
Copy link
Member

zanderso commented Jun 8, 2023 •
edited
Loading

This requires ensuring that docs on the wiki and website have been updated to match before it can land. It should also be preceded by a PSA to the internal mailing list.

@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 8, 2023

This requires ensuring that docs on the wiki and website have been updated to match before it can land. It should also be preceded by a PSA to the internal mailing list.

We already did all of that back in 2021. http://go/flutter-master2main the only missing part is to remove the mirroring and actually archive the branch.

@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 8, 2023

This requires ensuring that docs on the wiki and website have been updated to match before it can land. It should also be preceded by a PSA to the internal mailing list.

We already did all of that back in 2021. http://go/flutter-master2main the only missing part is to remove the mirroring and actually archive the branch.

Checking the website again and wiki to ensure we didn't miss anything.

@zanderso
Copy link
Member

zanderso commented Jun 8, 2023

This requires ensuring that docs on the wiki and website have been updated to match before it can land. It should also be preceded by a PSA to the internal mailing list.

We already did all of that back in 2021. http://go/flutter-master2main the only missing part is to remove the mirroring and actually archive the branch.

It would be amazing if there have been no regressions in 2 years ;-)

@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 8, 2023

uld be amazing if there have been no regressions in 2 years ;-)

Adding both website and wiki to the open source code search to simplify the search.

@chinmaygarde
Copy link
Member

chinmaygarde commented Jun 22, 2023

Are we still working on this one? Leaving it be or removing it is fine by me.

@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 22, 2023

I'm checking out the wiki and the website to ensure there are no references to engine/master

@godofredoc
Copy link
Contributor Author

godofredoc commented Jun 23, 2023

Updated wiki pages:

Website: no references to engine master branch.

website-cms:

flutter/flutter: no references to engine master branch.
flutter/engine: no references to engine master branch.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2023
@auto-submit auto-submit bot merged commit 74ef618 into flutter:main Jun 23, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
74ef61859 Remove master mirroring workflow. (flutter/engine#42681)
98c841d
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 060cd9c17df3 to 74ef61859bdc (3 revisions) (#…
b136f5f 
…129444)

flutter/engine@060cd9c...74ef618

2023-06-23 [email protected] Remove master mirroring workflow. (flutter/engine#42681)
2023-06-23 [email protected] Roll Fuchsia Mac SDK from 07vKo_Vaiy_Vw2xxb... to w-tUP3Ia2kfAaFNW1... (flutter/engine#43148)
2023-06-23 [email protected] Roll Skia from 9635d54210dc to 7b6aae68a11f (5 revisions) (flutter/engine#43147)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 07vKo_Vaiy_V to w-tUP3Ia2kfA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@godofredoc godofredoc deleted the remove_master_mirroring branch June 24, 2023 02:21
godofredoc added a commit that referenced this pull request Jun 26, 2023
@godofredoc
Revert "Remove master mirroring workflow. (#42681)"
30faac4 
This reverts commit 74ef618.
@godofredoc godofredoc mentioned this pull request Jun 26, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Jun 26, 2023
@godofredoc
Revert "Remove master mirroring workflow." (#43206)
7212bb6 
Reverts #42681
kjlubick pushed a commit to kjlubick/engine that referenced this pull request Jul 14, 2023
@godofredoc @kjlubick
Revert "Remove master mirroring workflow." (flutter#43206)
8918fbf 
Reverts flutter#42681
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @zanderso @chinmaygarde