This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove /#/ from home page URL #42598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2023
…128363) flutter/engine@ca49946...6f9df0f 2023-06-06 [email protected] [web] Remove /#/ from home page URL (flutter/engine#42598) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 5, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the
HashUrlStrategya bit cleaner (at least for the home page), let's get rid of the notorious/#/when the app is in the home page.Non-home pages continue to have a hash in them. After this PR, here are some example URL changes:
http://domain.com/#/=>http://domain.com/http://domain.com/#/page1=> (remains the same)This change is backwards compatible, i.e. if you write
http://domain.com/#/in the address bar, the app will load and open the home page correctly; and flutter will automatically change the URL tohttp://domain.com/.Fixes flutter/flutter#127608