This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) #42584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#41463) This reverts commit 2553def.
Contributor
Author
|
The only change in this PR compared to the previous version (#42330) is the 2-line change adding 2 calls to (That change does not appear in a separate commit because it had to be conflict-merged with the other PR when pulling forward.) |
Member
|
From PR triage: This is waiting on the Engine rolls to get unblocked to help isolate any issues rolling to the framework or g3. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 11, 2023
…128673) flutter/engine@788437e...9bb0a59 2023-06-11 [email protected] Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#42584) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero
added a commit
that referenced
this pull request
Jun 30, 2023
…lder" (#41463)" (#43358) Reverts #42584. (Thanks to @jonahwilliams for bisecting) With this change, layers are getting clipped incorrectly when rendering platform views in Wondrous.
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
…lder" (flutter#41463)" (flutter#43358) Reverts flutter#42584. (Thanks to @jonahwilliams for bisecting) With this change, layers are getting clipped incorrectly when rendering platform views in Wondrous.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2553def.
Fixes flutter/flutter#125338
This PR should fix the blendmode/color analysis that caused failures for #41463 as well as the bounds failures for inverted rectangles that caused failures for #42330 (incorporating the fix from #42556).
The description from the previous PR updated with the new name of the DL property:
This optimization avoids recording unnecessary render operations that will not affect the output and also eliminates the need for "draw detection" mechanisms like
DlOpSpyandCanvasSpyby remembering if any non-transparent operations were included. TheDlOpSpyunit tests were updated to check if the results from that object match the newDisplayList::modifies_transparent_black()method.Fixes flutter/flutter#125338
In addition, this change will unblock some other Issues: