This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[linux] Allow overriding aot_library_path #42555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dballard
force-pushed
the
set-linux-aot-library-path
branch
from
ecd1a3b to
32c31ad
Compare
cbracken
changed the title
robert-ancell
suggested changes
Jun 12, 2023
Contributor
robert-ancell
left a comment
robert-ancell
left a comment
There was a problem hiding this comment.
Seems to be missing the code to pass this path to the engine?
Member
|
@dballard Have you had a chance to address the feedback? (Desktop triage) |
Contributor
Author
|
@loic-sharma Not yet, been a busy few weeks but hoping to get back to this in the next few days, thanks for the reminder! |
dballard
force-pushed
the
set-linux-aot-library-path
branch
2 times, most recently
from
f5ca8c1 to
a9f7442
Compare
Contributor
Author
How so? I copied what |
Contributor
Sorry, yes. I missed the existing code was already there to do this. |
dballard
force-pushed
the
set-linux-aot-library-path
branch
from
a9f7442 to
15c9acd
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 10, 2023
…130238) flutter/engine@09c6ce4...ed3c553 2023-07-10 [email protected] [linux] Allow overriding aot_library_path (flutter/engine#42555) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Support overriding `aot_library_path` in `FLDartProject` on Linux. Fixes: flutter/flutter#128213 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support overriding
aot_library_pathinFLDartProjecton Linux.Fixes: flutter/flutter#128213
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.