[Android] Bump unit test robolectric version to 4.10.3 #42454
Conversation
| verify(surface, times(1)).lockHardwareCanvas(); | ||
| verify(surface, times(1)).unlockCanvasAndPost(canvas); | ||
| verifyNoMoreInteractions(surface); | ||
| verifyNoMoreInteractions(canvas); |
There was a problem hiding this comment.
No longer can be expected due to robolectric/robolectric#7279; there are now calls to draw that occur on canvas.
|
|
||
| @Implements(Resources.class) | ||
| public class SplashShadowResources { | ||
| public class SplashShadowResources extends ShadowResources { |
There was a problem hiding this comment.
Robolectric expects to find an extension of ShadowResources when @Implements(Resources.class) is specified, as per the docs.
|
|
||
| Context context = ApplicationProvider.getApplicationContext(); | ||
| View androidView = new View(context); | ||
| View androidView = mock(View.class); |
There was a problem hiding this comment.
Using the ApplicationProvider.getApplicationContext() context to create androidView is problematic because the call to attach in this method creates another View with the exact same context that is already added as a View to the relevant PlatformView, causing an error here.
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
I clicked update branch in addtion to approving this PR so that google testing can run.
Google testing isn't running due to what seems like a sync error, but I'm not sure how this change would affect them. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_unopt/1394/overview and https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_debug_engine/11000/overview are successful test runs. |
camsim99
added
the
autosubmit
…128147) flutter/engine@b4250ac...f3f6a02 2023-06-02 [email protected] Wrap concurrent message loop tasks in an autorelease pool on iOS/Mac platforms (flutter/engine#42459) 2023-06-02 [email protected] Update engine build config docs. (flutter/engine#41468) 2023-06-02 [email protected] [Android] Bump unit test robolectric version to 4.10.3 (flutter/engine#42454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
Bumps robolectric version for unit tests to 4.10.3, the latest and greatest. Should support running unit tests with API 33.
Pre-launch Checklist
///).