This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace use of Skia's private GrRectanizer with a copy of the equivalent code #42430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
May 30, 2023
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM as long as tests are passing.
@chinmaygarde fyi
Contributor
|
Looks like you have to update the license file and clang tidy timed out... |
chinmaygarde
approved these changes
May 30, 2023
Contributor
Author
|
Fix for seemingly unrelated clang-tidy failures: #42450 |
Contributor
|
@zanderso recently enabled some new lints, probably because you touched the file it's now getting scanned :) |
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 42430, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2023
…127979) flutter/engine@8e67cc3...b9860dc 2023-05-31 [email protected] Replace use of Skia's private GrRectanizer with a copy of the equivalent code (flutter/engine#42430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
andrewkolos
pushed a commit
to andrewkolos/flutter
that referenced
this pull request
May 31, 2023
…lutter#127979) flutter/engine@8e67cc3...b9860dc 2023-05-31 [email protected] Replace use of Skia's private GrRectanizer with a copy of the equivalent code (flutter/engine#42430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skia would like clients to not use their private types. This ports the same functionality into Flutter's codebase with tests.
The implementation was copied from Skia and then modified to match Flutter's style and have a unit test.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.