This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix unitialized SkRect #42403
Merged
Fix unitialized SkRect #42403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
Author
|
@Hixie, can this get a test exemption? |
flar
approved these changes
May 30, 2023
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
LGTM, we fixed this in other places and missed this one.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
…127890) flutter/engine@a6d3124...1ba8091 2023-05-30 [email protected] Handle a11y focus event on Ios and android (flutter/engine#41777) 2023-05-30 [email protected] Fix unitialized SkRect (flutter/engine#42403) 2023-05-30 [email protected] Update engine testing to use api 33 for android tests. (flutter/engine#42351) 2023-05-30 [email protected] Reland: "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (#40542) (flutter/engine#42418) 2023-05-30 [email protected] [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423) 2023-05-30 [email protected] Remove legacy xcode properties/dependencies (flutter/engine#42368) 2023-05-30 [email protected] Roll Skia from bab82f14da1a to fed417995ba9 (7 revisions) (flutter/engine#42424) 2023-05-30 [email protected] [Impeller] removed vulkan unit test csv (flutter/engine#42354) 2023-05-30 [email protected] Roll Skia from d22106cc40a0 to bab82f14da1a (7 revisions) (flutter/engine#42420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty SkRect needs to be created with
SkRect::MakeEmpty()otherwise the default value is undefined (and possibly garbage).If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.