This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Extract more PlatformViewMutator code #42361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extracts an extra method from `[FlutterMutatorView applyFlutterLayer:]` to perform the final PlatformViewContainer and PlatformView re-nesting in the view stack, then apply transforms, and finally apply the outer axis-aligned master clip rect around the whole thing. This is a refactoring for readability (primarily clearer parameterisation) and applies no semantic changes to the code. Issue: flutter/flutter#124490
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: code refactor with no semantic change |
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 27, 2023
…127738) flutter/engine@795db50...3426cb8 2023-05-27 [email protected] Roll Dart SDK from 14162b5f5a1a to e0caea366989 (3 revisions) (flutter/engine#42376) 2023-05-26 [email protected] Roll Fuchsia Mac SDK from c6-zqvlx2YtyGwGzJ... to f94C9eArSWIUjOTM6... (flutter/engine#42367) 2023-05-26 [email protected] Adding app lifecycle notification for macOS and Linux, add `hidden` state. (flutter/engine#40542) 2023-05-26 [email protected] Roll Dart SDK from bc65e3f5efa0 to 14162b5f5a1a (3 revisions) (flutter/engine#42366) 2023-05-26 [email protected] Roll Fuchsia Linux SDK from 9aZkaKhX4GslPUnbX... to 2-z8tqXe3ZkKqeb3e... (flutter/engine#42365) 2023-05-26 [email protected] Fix ci yaml roller caused by incorrect format (flutter/engine#42364) 2023-05-26 [email protected] [macOS] Extract more PlatformViewMutator code (flutter/engine#42361) 2023-05-26 [email protected] Enable bugprone-unchecked-optional-access, disable in files with warnings (flutter/engine#42359) 2023-05-26 [email protected] Roll Skia from ac897edeb16a to 8d475ae01f09 (9 revisions) (flutter/engine#42363) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9aZkaKhX4Gsl to 2-z8tqXe3ZkK fuchsia/sdk/core/mac-amd64 from c6-zqvlx2Yty to f94C9eArSWIU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts an extra method from
[FlutterMutatorView applyFlutterLayer:]to perform the final PlatformViewContainer and PlatformView re-nesting in the view stack, then apply transforms, and finally apply the outer axis-aligned master clip rect around the whole thing.This is a refactoring for readability (primarily clearer parameterisation) and applies no semantic changes to the code. This is the last in a series of refactoring applied to this method.
Issue: flutter/flutter#124490
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.