This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move benchmarks no upload to a test. #42356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
May 27, 2023
| { | ||
| "language": "bash", | ||
| "name": "Generate metrics test", | ||
| "script": "flutter/testing/benchmark/generate_metrics.sh" |
Member
There was a problem hiding this comment.
Changes to the upload script are not otherwise tested except by the dry-run here: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine_metrics.py#69, which we should retain.
Contributor
Author
There was a problem hiding this comment.
Added the upload as dry-run.
This is moving the execution of the benchmarks script to a test inside the existing host_relese configuration. It keeps the same coverage with and removes one build. Bug: flutter/flutter#127678
Contributor
Author
|
This is now ready for a second review. |
zanderso
approved these changes
Jun 2, 2023
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 2, 2023
…128142) flutter/engine@c6e9383...b4250ac 2023-06-02 [email protected] Manually roll ANGLE (flutter/engine#42169) 2023-06-02 [email protected] [Impeller] Fix a bugprone-unchecked-optional-access warning in SurfaceMTL (flutter/engine#42518) 2023-06-02 [email protected] [web] Move announcement live elements to the end of the DOM and make them `div`s instead of `label`s. (flutter/engine#42432) 2023-06-02 [email protected] Roll Fuchsia Mac SDK from JQRQ1nH1ILNA--N_b... to gcm-vsCu6IPUZZnN0... (flutter/engine#42515) 2023-06-02 [email protected] Add cpu as drone dimension to mac ios build. (flutter/engine#42514) 2023-06-02 [email protected] Move benchmarks no upload to a test. (flutter/engine#42356) 2023-06-02 [email protected] [Android] Change Linux Android Emulator Tests to run on a device running API 33 (flutter/engine#42492) 2023-06-02 [email protected] Roll Skia from 47b0db43f6a4 to daf2219fec54 (1 revision) (flutter/engine#42513) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from JQRQ1nH1ILNA to gcm-vsCu6IPU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is moving the execution of the benchmarks script to a test inside the existing host_relese configuration. It keeps the same coverage with and removes one build.
Bug: flutter/flutter#127678
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.