This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Checkout android and emsdk deps in linux. #42339
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to optimize the caches for builders that require those dependencies. Bug: flutter/flutter#127627
yusuf-goog
approved these changes
May 26, 2023
Contributor
|
Are we expecting |
Contributor
Author
Added them back, they were removed in an attempt to validate in presubmit. |
keyonghan
approved these changes
May 26, 2023
Contributor
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ricardoamador
approved these changes
May 26, 2023
Contributor
ricardoamador
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 26, 2023
…127698) flutter/engine@84f2fc1...ec7b0ae 2023-05-26 [email protected] Checkout android and emsdk deps in linux. (flutter/engine#42339) 2023-05-26 [email protected] [web] - Fix autofill group input ordering (flutter/engine#42268) 2023-05-26 [email protected] Roll Skia from 1622df035714 to ac897edeb16a (1 revision) (flutter/engine#42348) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
May 26, 2023
Follow up of #42339 Fixes: flutter/flutter#127709
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to optimize the caches for builders that require those dependencies.
Bug: flutter/flutter#127627
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.