Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@eyebrowsoffire
Copy link
Contributor

No description provided.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 25, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@godofredoc godofredoc self-requested a review May 25, 2023 19:04
@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@auto-submit auto-submit bot merged commit 8ddd6da into flutter:main May 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 25, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 25, 2023
…127619)

flutter/engine@6ff02c1...99f2653

2023-05-25 [email protected] Implement Web Codecs for Skwasm (flutter/engine#42184)
2023-05-25 [email protected] Move linux clang tidy to engine_v2. (flutter/engine#42112)
2023-05-25 [email protected] Roll Skia from 69d0aa065992 to e648bf802cd2 (11 revisions) (flutter/engine#42323)
2023-05-25 [email protected] Only use 8 cores for web test compilation. (flutter/engine#42321)
2023-05-25 [email protected] Roll Fuchsia Linux SDK from nLnQzTesaABpgroOl... to DNwJQMQZladAsKTjv... (flutter/engine#42322)
2023-05-25 [email protected] Dynamically link against system fontconfig (flutter/engine#40725)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from nLnQzTesaABp to DNwJQMQZladA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants