[Impeller] Add generic path for mask blurring #42308
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
force-pushed
the
bdero/colorsource-mask-blur
branch
from
607d42c to
495af12
Compare
bdero
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…127601) flutter/engine@195009b...515a4bf 2023-05-25 [email protected] Implement PlatformDispatcher.displays on web (flutter/engine#42297) 2023-05-25 [email protected] Roll Skia from b80e74dc4cda to 69d0aa065992 (3 revisions) (flutter/engine#42319) 2023-05-25 [email protected] [Impeller] Safely access snapshot in the pipeline blend filter (flutter/engine#42314) 2023-05-25 [email protected] [Impeller] Add generic path for mask blurring (flutter/engine#42308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Resolves flutter/flutter#127013.
Makes mask blurs work for most color source + geometry combinations. Crucially, this doesn't interfere with the fast paths for solid color RRect blurs (used for shadows).
I'll be addressing mask blurs for text in a follow-up.
Before:
After: