This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fix UV and color blending. #42293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2023 13:16
Contributor
Author
|
Basically we'd end up applying the UV mapping from the VerticesGeometry twice, whereas the second time we really just want to sample the snapshotted rectangle. I think we should update this implementation to avoid the snapshot for image sources, but that is a more involved change |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 25, 2023
…127544) flutter/engine@6a36109...1bed04a 2023-05-24 [email protected] [Impeller] Turn on vulkan tests for mac CI. (flutter/engine#42225) 2023-05-24 [email protected] [Impeller] fix UV and color blending. (flutter/engine#42293) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
May 26, 2023
Fixes flutter/flutter#127486 Combinations of UV mapping and color blending would cause us to double apply the UV mapping which rendered either nothing or garbage. Before:  After: 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#127486
Combinations of UV mapping and color blending would cause us to double apply the UV mapping which rendered either nothing or garbage.
Before:
After: