This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] - Fix autofill group input ordering #42268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
mdebbar
reviewed
May 24, 2023
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
Once tests are added, please re-ping me for re-review.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 26, 2023
…127698) flutter/engine@84f2fc1...ec7b0ae 2023-05-26 [email protected] Checkout android and emsdk deps in linux. (flutter/engine#42339) 2023-05-26 [email protected] [web] - Fix autofill group input ordering (flutter/engine#42268) 2023-05-26 [email protected] Roll Skia from 1622df035714 to ac897edeb16a (1 revision) (flutter/engine#42348) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Is there a good way to know when this would be rolled into stable or hotfixed? I tried to view on https://flutter-dashboard.appspot.com/#/build but it was a bit confusing |
|
Thanks for the fix. Has this been reverted? It works in beta channel for |
|
Tested on stable 3.13 and bitwarden can autofill from the extension but no context menu shows up in the textfield |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordering of input elements inside of the DOM tree for autofill groups does not reflect the order of the form rendered on screen. This is causing some issues with password managers and autofill, specifically Bitwarden.
We are currently always appending the currently focused input element to the end of the form.
This leads to a tree that appears out of order:
This fix is tracking the position of where the focused input node should be inserted and inserting it there, rather than always at the end of the form. Once the tree is ordered correctly, Bitwarden's autofill logic works in Flutter forms.
Tree order after fix:
Fixes flutter/flutter#61301
Fixes flutter/flutter#68005
Pre-launch Checklist
///).