This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Skip and ignore boringssl/src/rust when looking for the licenses. #42210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
third_praty/boringssl/src/rust/bssl-crypto/deny.toml triggers 'potential license', '.toml' are configuration files.
Member
Author
|
This is to unblock dart->engine roller |
zanderso
reviewed
May 22, 2023
tools/licenses/lib/paths.dart
Outdated
| r'codereview.settings', | ||
| r'coderules.txt', | ||
| r'configure-ac-style.md', | ||
| r'deny.toml', |
Member
There was a problem hiding this comment.
I think we should probably just skip everything under the rust bindings directory under https://boringssl.googlesource.com/boringssl/+/refs/heads/master/rust since we don't build/ship them. That exclusion would go above next to the other paths we exclude from boringssl.
zanderso
approved these changes
May 22, 2023
aam
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 22, 2023
…127352) flutter/engine@1ed9fc0...a342a91 2023-05-22 [email protected] Roll Skia from 2612bb159848 to d448fe07ea46 (5 revisions) (flutter/engine#42213) 2023-05-22 [email protected] Skip and ignore boringssl/src/rust when looking for the licenses. (flutter/engine#42210) 2023-05-22 [email protected] [Impeller] Create reusable prefix sum. (flutter/engine#42167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127352) flutter/engine@1ed9fc0...a342a91 2023-05-22 [email protected] Roll Skia from 2612bb159848 to d448fe07ea46 (5 revisions) (flutter/engine#42213) 2023-05-22 [email protected] Skip and ignore boringssl/src/rust when looking for the licenses. (flutter/engine#42210) 2023-05-22 [email protected] [Impeller] Create reusable prefix sum. (flutter/engine#42167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
third_party/boringssl/src/rust/bssl-crypto/deny.toml coming in as part of https://dart-review.googlesource.com/c/sdk/+/304210 triggers 'potential license' license script error.
Rust sources of boringssl are not included into flutter, don't need to be scanned for licenses.