Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] [Impeller] Fix the issue that 'coverage_coords' is incorrectly calculated in 'FillPathGeometry::GetPositionUVBuffer' #42155 #42180

Merged
auto-submit merged 1 commit into from
May 21, 2023
Merged

[CP] [Impeller] Fix the issue that 'coverage_coords' is incorrectly calculated in 'FillPathGeometry::GetPositionUVBuffer' #42155 #42180

auto-submit merged 1 commit into from
May 21, 2023

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented May 20, 2023

cp of #42155

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ColdPaleLight
[CP] [Impeller] Fix the issue that 'coverage_coords' is incorrectly c…
e4925bb 
…alculated in 'FillPathGeometry::GetPositionUVBuffer' flutter#42155
@ColdPaleLight ColdPaleLight mentioned this pull request May 20, 2023
Closed
@ColdPaleLight ColdPaleLight requested review from dnfield and jonahwilliams and removed request for dnfield May 20, 2023 01:18
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2023
@auto-submit auto-submit bot merged commit 8cbd2bf into flutter:flutter-3.10-candidate.1 May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ColdPaleLight @dnfield @itsjustkevin