Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move SkSurface::MakeNull to SkSurfaces::Null #42158

Merged
kjlubick merged 6 commits into from
May 20, 2023
Merged

Move SkSurface::MakeNull to SkSurfaces::Null #42158

kjlubick merged 6 commits into from
May 20, 2023

Conversation

@kjlubick
Copy link
Contributor

@kjlubick kjlubick commented May 19, 2023

In https://skia-review.googlesource.com/c/skia/+/696537 (and earlier in https://skia-review.googlesource.com/c/skia/+/687639), Skia moved all SkSurface factories. This changes the last calls of the old static methods to the methods in the SkSurfaces namespace

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@kjlubick kjlubick merged commit f939b5f into flutter:main May 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2023
@engine-flutter-autoroll
f939b5f06 Move SkSurface::MakeNull to SkSurfaces::Null (flutter/engin…
00e0ab5 
…e#42158)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2023
@engine-flutter-autoroll
f939b5f06 Move SkSurface::MakeNull to SkSurfaces::Null (flutter/engin…
d53e700 
…e#42158)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2023
@engine-flutter-autoroll
f939b5f06 Move SkSurface::MakeNull to SkSurfaces::Null (flutter/engin…
06c7d81 
…e#42158)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2023
@engine-flutter-autoroll
f939b5f06 Move SkSurface::MakeNull to SkSurfaces::Null (flutter/engin…
3f6949e 
…e#42158)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2023
@engine-flutter-autoroll
f939b5f06 Move SkSurface::MakeNull to SkSurfaces::Null (flutter/engin…
2edbaf2 
…e#42158)
zanderso pushed a commit to flutter/flutter that referenced this pull request May 22, 2023
@engine-flutter-autoroll
Roll Flutter Engine from aac09195688d to f0f3fe729a91 (16 revisions) (#…
fdc6c13 
…127292)

flutter/engine@aac0919...f0f3fe7

2023-05-21 [email protected] Roll Skia from 7c7dff949a27 to
5b2005e47bf3 (1 revision) (flutter/engine#42199)
2023-05-21 [email protected] Roll Fuchsia Linux SDK from
gQ989rlKAuTJHQR-C... to 88pzkUAkSKsJrNG38... (flutter/engine#42198)
2023-05-21 [email protected] Roll Fuchsia Mac SDK from
868_67npyO8nD_JCx... to JU-dKW3CQIUzhbqWE... (flutter/engine#42197)
2023-05-21 [email protected] Roll Skia from a60bfcb01af9 to
7c7dff949a27 (1 revision) (flutter/engine#42195)
2023-05-20 [email protected] Roll Fuchsia Linux SDK from
c_fRDyBVZX-MwW5fS... to gQ989rlKAuTJHQR-C... (flutter/engine#42194)
2023-05-20 [email protected] Roll Skia from f3e9cb7d37fd to
a60bfcb01af9 (1 revision) (flutter/engine#42193)
2023-05-20 [email protected] Roll Fuchsia Mac SDK from
sfLkc5VBFU6UkljF6... to 868_67npyO8nD_JCx... (flutter/engine#42191)
2023-05-20 [email protected] Move SkSurface::MakeNull to
SkSurfaces::Null (flutter/engine#42158)
2023-05-20 [email protected] Roll Fuchsia Linux SDK from
TWjmvLCOnYAUgAzvT... to c_fRDyBVZX-MwW5fS... (flutter/engine#42189)
2023-05-20 [email protected] Roll Skia from b4a4782cf89d to
f3e9cb7d37fd (1 revision) (flutter/engine#42188)
2023-05-20 [email protected] Roll Fuchsia Mac SDK from
pwdDQgM88sqLmZczj... to sfLkc5VBFU6UkljF6... (flutter/engine#42187)
2023-05-20 [email protected] Roll Skia from 7202b405f061 to
b4a4782cf89d (19 revisions) (flutter/engine#42185)
2023-05-20 [email protected] [Impeller] avoid creating multiple
concurrent message loops for Andorid Vulkan (flutter/engine#42146)
2023-05-20 [email protected] Implement
`ImageFilter`/`ColorFilter`/`MaskFilter` in Skwasm
(flutter/engine#42088)
2023-05-20 [email protected] [Impeller] Made
other vulkan objects cleanup properly. (flutter/engine#42113)
2023-05-19 [email protected] [Impeller] Fix the issue that
'coverage_coords' is incorrectly calculated in
'FillPathGeometry::GetPositionUVBuffer' (flutter/engine#42155)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TWjmvLCOnYAU to 88pzkUAkSKsJ
  fuchsia/sdk/core/mac-amd64 from pwdDQgM88sqL to JU-dKW3CQIUz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Flutter Engine from aac09195688d to f0f3fe729a91 (16 revisions) (f…
6e0786c 
…lutter#127292)

flutter/engine@aac0919...f0f3fe7

2023-05-21 [email protected] Roll Skia from 7c7dff949a27 to
5b2005e47bf3 (1 revision) (flutter/engine#42199)
2023-05-21 [email protected] Roll Fuchsia Linux SDK from
gQ989rlKAuTJHQR-C... to 88pzkUAkSKsJrNG38... (flutter/engine#42198)
2023-05-21 [email protected] Roll Fuchsia Mac SDK from
868_67npyO8nD_JCx... to JU-dKW3CQIUzhbqWE... (flutter/engine#42197)
2023-05-21 [email protected] Roll Skia from a60bfcb01af9 to
7c7dff949a27 (1 revision) (flutter/engine#42195)
2023-05-20 [email protected] Roll Fuchsia Linux SDK from
c_fRDyBVZX-MwW5fS... to gQ989rlKAuTJHQR-C... (flutter/engine#42194)
2023-05-20 [email protected] Roll Skia from f3e9cb7d37fd to
a60bfcb01af9 (1 revision) (flutter/engine#42193)
2023-05-20 [email protected] Roll Fuchsia Mac SDK from
sfLkc5VBFU6UkljF6... to 868_67npyO8nD_JCx... (flutter/engine#42191)
2023-05-20 [email protected] Move SkSurface::MakeNull to
SkSurfaces::Null (flutter/engine#42158)
2023-05-20 [email protected] Roll Fuchsia Linux SDK from
TWjmvLCOnYAUgAzvT... to c_fRDyBVZX-MwW5fS... (flutter/engine#42189)
2023-05-20 [email protected] Roll Skia from b4a4782cf89d to
f3e9cb7d37fd (1 revision) (flutter/engine#42188)
2023-05-20 [email protected] Roll Fuchsia Mac SDK from
pwdDQgM88sqLmZczj... to sfLkc5VBFU6UkljF6... (flutter/engine#42187)
2023-05-20 [email protected] Roll Skia from 7202b405f061 to
b4a4782cf89d (19 revisions) (flutter/engine#42185)
2023-05-20 [email protected] [Impeller] avoid creating multiple
concurrent message loops for Andorid Vulkan (flutter/engine#42146)
2023-05-20 [email protected] Implement
`ImageFilter`/`ColorFilter`/`MaskFilter` in Skwasm
(flutter/engine#42088)
2023-05-20 [email protected] [Impeller] Made
other vulkan objects cleanup properly. (flutter/engine#42113)
2023-05-19 [email protected] [Impeller] Fix the issue that
'coverage_coords' is incorrectly calculated in
'FillPathGeometry::GetPositionUVBuffer' (flutter/engine#42155)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TWjmvLCOnYAU to 88pzkUAkSKsJ
  fuchsia/sdk/core/mac-amd64 from pwdDQgM88sqL to JU-dKW3CQIUz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
noxi7601 pushed a commit to noxi7601/skia that referenced this pull request May 25, 2023
@kjlubick
Reland "Remove legacy SkSurface factories"
b5e6911 
This is a reland of commit 280b585

flutter->G3 has landed, so we should be good to go

Original change's description:
> Remove legacy SkSurface factories
>
> All clients have been migrated, e.g.:
>  - https://crrev.com/c/4518554
>  - http://ag/23214919
>  - flutter/engine#42158
>  - http://ag/23339542
>
> Bug: skia:13983
> Change-Id: I5f48f7c4c9ad6bbfbd08f5666dd6d4eb63bd6a8a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/700223
> Commit-Queue: Kevin Lubick <[email protected]>
> Reviewed-by: Brian Osman <[email protected]>

Bug: skia:13983
Change-Id: I2f80663d316fc7c81a5909d9dd41b4fc51bc51e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/701519
Reviewed-by: Brian Osman <[email protected]>
@kjlubick kjlubick deleted the make-null branch August 3, 2023 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android platform-fuchsia

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kjlubick @jason-simmons