This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Remove GN staging flag for save layer bounds" #42026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a491992.
8 tasks
zanderso
approved these changes
May 14, 2023
CaseyHillers
added
the
autosubmit
Contributor
|
First, this change was expected to cause golden file failures. The new behavior is intentional, but not backwards compatible. Second, it would seem to me that this kind of golden failure is exactly why this behavior has been bad. Those avatars are set inside a circular clip for a reason and this change fills that circular clip. The prior behavior failed to fill the circular clip because the ColorFilter did not fill past the implicit bounds of the children. |
Contributor
|
cc @lhkbob |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2023
Contributor
|
@flar's assessment is correct. The golden failure is expected and the reference image should have been marked incorrect, while the new fully-filled circle is correct. |
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 14, 2023
…126783) flutter/engine@a1ccf90...326de1d 2023-05-14 [email protected] Roll Dart SDK from 005648f027a3 to 7d6324d5488b (1 revision) (flutter/engine#42027) 2023-05-14 [email protected] Revert "Remove GN staging flag for save layer bounds" (flutter/engine#42026) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
added a commit
that referenced
this pull request
May 15, 2023
This reverts commit dd8d76d.
Contributor
Author
|
Reland available in #42029. Thanks for investigating! |
auto-submit bot
pushed a commit
that referenced
this pull request
May 15, 2023
Reverts #42026 After investigating, this is a bug fix for the scubas.
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126783) flutter/engine@a1ccf90...326de1d 2023-05-14 [email protected] Roll Dart SDK from 005648f027a3 to 7d6324d5488b (1 revision) (flutter/engine#42027) 2023-05-14 [email protected] Revert "Remove GN staging flag for save layer bounds" (flutter/engine#42026) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #41940
See b/282115120
This caused a golden failure on Google Testing where a rectangular avatar became circular.