This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Report displays for macOS #41998
Merged
Report displays for macOS #41998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
May 12, 2023
Contributor
Author
import 'dart:ui';
// import 'package:flutter/widgets.dart';
// import 'package:flutter/services.dart';
void main() {
// WidgetsFlutterBinding.ensureInitialized();
// SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);
print(PlatformDispatcher.instance.displays.toList());
print(PlatformDispatcher.instance.implicitView!.display);
PlatformDispatcher.instance.onMetricsChanged = () {
print(PlatformDispatcher.instance.displays.toList());
print(PlatformDispatcher.instance.implicitView!.display);
};
}Is the simple Dart application I've been using to test this. In a default Flutter app it's working well to report display sizes when the window gets moved around to different monitors or the monitor configuration changes. |
loic-sharma
reviewed
May 12, 2023
loic-sharma
reviewed
May 12, 2023
cbracken
reviewed
May 13, 2023
shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm
Outdated
Show resolved
Hide resolved
loic-sharma
approved these changes
May 15, 2023
Member
There was a problem hiding this comment.
LGTM once you've double-checked FlutterWindowMetricsEvent.display_id's type: #41998 (comment)
Please make sure to also get Chris's approval for macOS embedder changes and Chris's/Chinmay's approval for embedder API changes.
dnfield
commented
May 17, 2023
| /// Display refers to a graphics hardware system consisting of a framebuffer, | ||
| /// typically a monitor or a screen. This ID is unique per display and is | ||
| /// stable until the Flutter application restarts. | ||
| typedef uint64_t FlutterEngineDisplayId; |
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 17, 2023
…127043) flutter/engine@47fd496...0ae3719 2023-05-17 [email protected] Report displays for macOS (flutter/engine#41998) 2023-05-17 [email protected] Fix bounds when painting style is stroke width for image shaders (flutter/engine#42052) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127043) flutter/engine@47fd496...0ae3719 2023-05-17 [email protected] Report displays for macOS (flutter/engine#41998) 2023-05-17 [email protected] Fix bounds when painting style is stroke width for image shaders (flutter/engine#42052) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#125939 and flutter/flutter#125938 for macOS
fixes flutter/flutter#121352