Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

Both builds have been running successfully. This PR moves Windows Unopt to staging and Windows windows_unopt to prod.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Both builds have been running successfully. This PR moves Windows Unopt
to staging and Windows windows_unopt to prod.
@godofredoc godofredoc requested a review from zanderso May 9, 2023 18:19
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2023
@auto-submit auto-submit bot merged commit 46544b1 into flutter:main May 9, 2023
@godofredoc godofredoc deleted the move_win_unopt_prod branch May 9, 2023 20:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request May 10, 2023
…ions) (#126445)

Manual roll requested by [email protected]

flutter/engine@78f41a8...10ac36c

2023-05-09 [email protected] Implement text rendering in Skwasm
(flutter/engine#41832)
2023-05-09 [email protected] Roll Fuchsia Linux SDK from
leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876)
2023-05-09 [email protected] [Impeller]
started cleaning up pools when devices are deleted
(flutter/engine#41857)
2023-05-09 [email protected] Roll Fuchsia Mac SDK from
c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874)
2023-05-09 [email protected] Move linux_license to engine v2.
(flutter/engine#41863)
2023-05-09 [email protected] Replace Windows Unopt with the engine
v2 version. (flutter/engine#41861)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne
  fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
godofredoc added a commit that referenced this pull request May 18, 2023
CP: 46544b1
## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…ions) (flutter#126445)

Manual roll requested by [email protected]

flutter/engine@78f41a8...10ac36c

2023-05-09 [email protected] Implement text rendering in Skwasm
(flutter/engine#41832)
2023-05-09 [email protected] Roll Fuchsia Linux SDK from
leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876)
2023-05-09 [email protected] [Impeller]
started cleaning up pools when devices are deleted
(flutter/engine#41857)
2023-05-09 [email protected] Roll Fuchsia Mac SDK from
c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874)
2023-05-09 [email protected] Move linux_license to engine v2.
(flutter/engine#41863)
2023-05-09 [email protected] Replace Windows Unopt with the engine
v2 version. (flutter/engine#41861)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne
  fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants