Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CP: Replace legacy linux unopt with engine v2. (#41757) #41844

Merged
godofredoc merged 4 commits into from
May 11, 2023
Merged

CP: Replace legacy linux unopt with engine v2. (#41757) #41844

godofredoc merged 4 commits into from
May 11, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented May 9, 2023

CP: 4853667

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Replace legacy linux unopt with engine v2. (#41757)
af3cd98 
This moves the legacy linux unopt build to staging and the engine v2 version to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@godofredoc godofredoc changed the base branch from main to flutter-3.11-candidate.0 May 9, 2023 02:32
@godofredoc godofredoc mentioned this pull request May 10, 2023
Closed
@godofredoc godofredoc requested a review from XilaiZhang May 11, 2023 00:23
XilaiZhang
XilaiZhang approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc merged commit 1bb5566 into flutter:flutter-3.11-candidate.0 May 11, 2023
@godofredoc godofredoc deleted the beta_cp_4 branch May 11, 2023 06:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @XilaiZhang