Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@goderbauer
Copy link
Member

The engine roll is currently failing (https://cirrus-ci.com/task/5475027185827840?logs=main#L172) because of a doc issue introduced by #41685. This fixes the doc issue.

The engine roll is currently failing (https://cirrus-ci.com/task/5475027185827840?logs=main#L172) because of a doc issue introduced by #41685. This fixes the doc issue.
@goderbauer goderbauer requested a review from dnfield May 8, 2023 09:57
Copy link
Member

@mraleph mraleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023
@auto-submit auto-submit bot merged commit c42dd23 into main May 8, 2023
@auto-submit auto-submit bot deleted the goderbauer-patch-1 branch May 8, 2023 10:57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 8, 2023
…126262)

flutter/engine@23f730e...c42dd23

2023-05-08 [email protected] Fix doc to fix engine roll (flutter/engine#41812)
2023-05-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.2 to 2.3.3 (flutter/engine#41811)
2023-05-08 [email protected] Roll Skia from 802eb7f66fc5 to 5f7e572995b1 (1 revision) (flutter/engine#41809)
2023-05-08 [email protected] Roll Skia from f9bef8f7bdb5 to 802eb7f66fc5 (1 revision) (flutter/engine#41807)
2023-05-08 [email protected] Roll Skia from 148ebc0596b7 to f9bef8f7bdb5 (1 revision) (flutter/engine#41806)
2023-05-08 [email protected] Roll Fuchsia Mac SDK from VD0zJZ-ezOAfA9O1s... to KZrdNPIOcs5m2MqV_... (flutter/engine#41805)
2023-05-07 [email protected] Roll Skia from 642ba306e140 to 148ebc0596b7 (1 revision) (flutter/engine#41804)
2023-05-07 [email protected] Roll Skia from 8a93b289c2ed to 642ba306e140 (1 revision) (flutter/engine#41802)
2023-05-07 [email protected] Roll ICU from d8daa943f64c to a2961dc659b4 (2 revisions) (flutter/engine#41801)
2023-05-07 [email protected] Roll Fuchsia Mac SDK from k4NzlntuagXZIlCJg... to VD0zJZ-ezOAfA9O1s... (flutter/engine#41800)
2023-05-07 [email protected] Roll Fuchsia Mac SDK from FFOWihz4lzOeDHmNj... to k4NzlntuagXZIlCJg... (flutter/engine#41799)
2023-05-06 [email protected] Roll Dart SDK from d04e8b571819 to ab64c4a56e2c (1 revision) (flutter/engine#41798)
2023-05-06 [email protected] Add a `Display` API to dart:ui that reports the physical size, DPR, and refresh rate of the main display (flutter/engine#41685)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from FFOWihz4lzOe to KZrdNPIOcs5m

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@dnfield
Copy link
Contributor

dnfield commented May 8, 2023

Whups

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants