This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Handle a11y focus event on Ios and android #41777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
8 tasks
hannah-hyj
changed the title
chunhtai
reviewed
May 10, 2023
shell/platform/android/io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/view/AccessibilityBridge.java
Outdated
Show resolved
Hide resolved
...atform/android/test/io/flutter/embedding/engine/systemchannels/AccessibilityChannelTest.java
Show resolved
Hide resolved
...atform/android/test/io/flutter/embedding/engine/systemchannels/AccessibilityChannelTest.java
Outdated
Show resolved
Hide resolved
shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm
Outdated
Show resolved
Hide resolved
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
chunhtai
reviewed
May 11, 2023
...atform/android/test/io/flutter/embedding/engine/systemchannels/AccessibilityChannelTest.java
Show resolved
Hide resolved
shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm
Outdated
Show resolved
Hide resolved
chunhtai
approved these changes
May 16, 2023
| ArgumentCaptor.forClass(AccessibilityEvent.class); | ||
| verify(mockParent).requestSendAccessibilityEvent(eq(mockRootView), eventCaptor.capture()); | ||
| AccessibilityEvent event = eventCaptor.getAllValues().get(0); | ||
| assertEquals(event.getEventType(), AccessibilityEvent.TYPE_VIEW_FOCUSED); |
Member
Author
There was a problem hiding this comment.
I tested nodeId in AccessibilityChannelTest.java
And there is no public api to get id from AccessibilityEvent.
Contributor
There was a problem hiding this comment.
This seems to not be addressed yet
per our offline discussion we talked previously, we can create a mocked event spy on the setSource
Contributor
camsim99
approved these changes
May 17, 2023
| ArgumentCaptor.forClass(AccessibilityEvent.class); | ||
| verify(mockParent).requestSendAccessibilityEvent(eq(mockRootView), eventCaptor.capture()); | ||
| AccessibilityEvent event = eventCaptor.getAllValues().get(0); | ||
| assertEquals(event.getEventType(), AccessibilityEvent.TYPE_VIEW_FOCUSED); |
vashworth
reviewed
May 17, 2023
| } | ||
| if ([type isEqualToString:@"focus"]) { | ||
| SemanticsObject* node = objects_.get()[annotatedEvent[@"nodeId"]]; | ||
| ios_delegate_->PostAccessibilityNotification(UIAccessibilityLayoutChangedNotification, node); |
Contributor
There was a problem hiding this comment.
What happens if node is nil? Seems like nil is an OK arg, but just double checking
Member
Author
There was a problem hiding this comment.
Tested in my device, if node is nil, nothing will happen, the focus will not be changed
Member
|
Are we blocked on this? |
Contributor
|
Nope. I think we can land it with @vashworth's stamp |
hannah-hyj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
…127890) flutter/engine@a6d3124...1ba8091 2023-05-30 [email protected] Handle a11y focus event on Ios and android (flutter/engine#41777) 2023-05-30 [email protected] Fix unitialized SkRect (flutter/engine#42403) 2023-05-30 [email protected] Update engine testing to use api 33 for android tests. (flutter/engine#42351) 2023-05-30 [email protected] Reland: "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (#40542) (flutter/engine#42418) 2023-05-30 [email protected] [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423) 2023-05-30 [email protected] Remove legacy xcode properties/dependencies (flutter/engine#42368) 2023-05-30 [email protected] Roll Skia from bab82f14da1a to fed417995ba9 (7 revisions) (flutter/engine#42424) 2023-05-30 [email protected] [Impeller] removed vulkan unit test csv (flutter/engine#42354) 2023-05-30 [email protected] Roll Skia from d22106cc40a0 to bab82f14da1a (7 revisions) (flutter/engine#42420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2023
issue: #94523 engine pr: flutter/engine#41777
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
framework change:flutter/flutter#126171
issue: flutter/flutter#94523
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.