This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow default out_dir for fuchsia symbols upload. #41776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows passing target files as relative to the src folder. This is required for migrating the fuchsia builds to engine_v2.
zanderso
approved these changes
May 5, 2023
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 5, 2023
…126174) flutter/engine@f3efe11...6b467df 2023-05-05 [email protected] Roll Skia from 1a1c7db436e4 to d6149a13d696 (6 revisions) (flutter/engine#41779) 2023-05-05 [email protected] Replace legacy linux unopt with engine v2. (flutter/engine#41757) 2023-05-05 [email protected] Allow default out_dir for fuchsia symbols upload. (flutter/engine#41776) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows passing target files as relative to the src folder. This is required for migrating the fuchsia builds to engine_v2.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.