Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented May 4, 2023

This relands #41246, which had to be reverted due to some issues parsing the font manifest.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 4, 2023
@eyebrowsoffire eyebrowsoffire marked this pull request as draft May 4, 2023 23:57
@eyebrowsoffire eyebrowsoffire marked this pull request as ready for review May 5, 2023 00:15
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023
@auto-submit auto-submit bot merged commit a697088 into main May 8, 2023
@auto-submit auto-submit bot deleted the revert-41750-revert-41246-skwasm_fonts branch May 8, 2023 18:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 8, 2023
…126288)

flutter/engine@d9184ce...8d3a816

2023-05-08 [email protected] Roll Skia from 30a368d502bf to 951eb9653163 (4 revisions) (flutter/engine#41820)
2023-05-08 [email protected] Reland "Skwasm Font Loading (flutter/engine#41756)
2023-05-08 [email protected] Roll Fuchsia Mac SDK from KZrdNPIOcs5m2MqV_... to oGF4h14qc40l5ANL3... (flutter/engine#41819)
2023-05-08 [email protected] Roll Dart SDK from 855e2764c295 to a8b6687327d6 (1 revision) (flutter/engine#41817)
2023-05-08 [email protected] Roll Skia from 64ba57381c94 to 30a368d502bf (1 revision) (flutter/engine#41816)
2023-05-08 [email protected] Add linux license engine v2 build. (flutter/engine#41797)
2023-05-08 [email protected] Windows unopt configuration. (flutter/engine#41785)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from KZrdNPIOcs5m to oGF4h14qc40l

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants