This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib #41720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s libfFlutter.dylib This would have helped me figure out why I wasn't getting the same failures as on CI more quickly.
jmagman
reviewed
May 4, 2023
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
What if there were no changes to the libFlutter but I'm iterating on the tests themselves?
Contributor
Author
Then the test dylib will be newer and this will pass. |
zanderso
approved these changes
May 4, 2023
| flutter_dylib = os.path.join(tmp_out_dir, 'libFlutter.dylib') | ||
| flutter_dylib_time = os.path.getmtime(flutter_dylib) | ||
|
|
||
| final_message = '%s is older than %s. Please run the following commands: \n%s' % ( |
Member
There was a problem hiding this comment.
autoninja is deprecated. Could you also change line 625 to be 'ninja -C ...' instead?
dnfield
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2023
…t as new as libFlutter.dylib (flutter/engine#41720)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 4, 2023
…126037) flutter/engine@ee65be7...da45a21 2023-05-04 [email protected] Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib (flutter/engine#41720) 2023-05-04 [email protected] [Impeller] Remove the DrawPaint->Clear optimization (flutter/engine#41711) 2023-05-03 [email protected] Roll Dart SDK from 3cfcfb24bc6a to 59787216f670 (2 revisions) (flutter/engine#41718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
…as new as libFlutter.dylib" (#44690) Reverts #41720 Fixes flutter/flutter#131899
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…as new as libFlutter.dylib" (flutter#44690) Reverts flutter#41720 Fixes flutter/flutter#131899
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have helped me figure out why I wasn't getting the same failures as on CI more quickly.