This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Remove view ID from public #41712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
May 3, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm! Shout if you need any backup on proposing this as a cherry-pick.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 4, 2023
…126027) flutter/engine@a0906bd...85516ec 2023-05-03 [email protected] [macOS] Remove view ID from public (flutter/engine#41712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of #39958, but only contains the minimal changes that removes all references to viewId from public interfaces, reverting these changes from #39576.
Flutter doesn't really support multi-view anyway. These methods currently only works for view 0. We better remove them until we mark multi-view stable. It was a mistake that I decided to add them to public interfaces.
For the reason why #39958 failed, I'm pretty sure it's the change to platform_dispatcher.dart that mysteriously and unintentionally appeared in the change list.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.