This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add relative path support for malioc_diff. #41703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative paths are required for integrating this tool as a test in engine v2.
zanderso
reviewed
May 3, 2023
zanderso
reviewed
May 3, 2023
impeller/tools/malioc_diff.py
Outdated
|
|
||
| # Generate full paths if relative ones are provided with before and | ||
| # after taking precedence. | ||
| args.before = ( |
Member
There was a problem hiding this comment.
How does this fail when neither --before nor --before-relative-to-src is provided. (Same question for the after versions.) Maybe putting the fallback logic in the argument validation in validate_args would be more clear?
Contributor
Author
There was a problem hiding this comment.
Moved it to the validation method and added some extra validations.
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 4, 2023
…126032) flutter/engine@85516ec...ee65be7 2023-05-03 [email protected] Add relative path support for malioc_diff. (flutter/engine#41703) 2023-05-03 [email protected] Roll Fuchsia Mac SDK from WAfNudyWPOGyWSpZD... to LCajvqTauUudC-7RW... (flutter/engine#41716) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from WAfNudyWPOGy to LCajvqTauUud If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
drewroengoogle
pushed a commit
that referenced
this pull request
Aug 2, 2023
Relative paths are required for integrating this tool as a test in engine v2. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
XilaiZhang
pushed a commit
that referenced
this pull request
Aug 2, 2023
Relative paths are required for integrating this tool as a test in engine v2. Co-authored-by: godofredoc <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative paths are required for integrating this tool as a test in engine v2.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.