This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Return keyboard pressed state #41695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
force-pushed
the
android_listen_and_answer_to_keyboard_pressed_state_queries
branch
5 times, most recently
from
df8c8a9 to
2364127
Compare
bleroux
force-pushed
the
android_listen_and_answer_to_keyboard_pressed_state_queries
branch
from
2364127 to
e04745d
Compare
dnfield
reviewed
May 4, 2023
shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyboardChannel.java
Outdated
Show resolved
Hide resolved
Contributor
|
Tagged a couple people who are more up to date on the Android Keyboard stack than I am at this point. |
justinmc
reviewed
May 4, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM from my point of view, maybe @dkwingsmt should have the final say.
shell/platform/android/io/flutter/embedding/android/KeyEmbedderResponder.java
Outdated
Show resolved
Hide resolved
Member
|
Ping @dkwingsmt for a second review. |
dkwingsmt
approved these changes
May 18, 2023
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM, sorry, I read it a while ago and thought I clicked approval but didn't.
bleroux
added
the
autosubmit
bleroux
deleted the
android_listen_and_answer_to_keyboard_pressed_state_queries
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 18, 2023
…127143) flutter/engine@c7c679d...17227c1 2023-05-18 [email protected] [Android] Return keyboard pressed state (flutter/engine#41695) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127143) flutter/engine@c7c679d...17227c1 2023-05-18 [email protected] [Android] Return keyboard pressed state (flutter/engine#41695) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dkwingsmt
added a commit
that referenced
this pull request
Jun 7, 2023
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Jun 8, 2023
Reverts flutter#41695 due to internal bug report b/284945818. cc @bleroux let's investigate some day.
CaseyHillers
pushed a commit
that referenced
this pull request
Jun 8, 2023
Reverts #41695 due to internal bug report b/284945818. b/286341060 Co-authored-by: Tong Mu <[email protected]>
bleroux
restored the
android_listen_and_answer_to_keyboard_pressed_state_queries
branch
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Jun 13, 2023
Reverts flutter#41695 due to internal bug report b/284945818. cc @bleroux let's investigate some day.
XilaiZhang
pushed a commit
to XilaiZhang/engine
that referenced
this pull request
Jun 13, 2023
Reverts flutter#41695 due to internal bug report b/284945818. cc @bleroux let's investigate some day.
CaseyHillers
pushed a commit
that referenced
this pull request
Jun 13, 2023
Reverts #41695 due to internal bug report b/284945818. cherry pick request was filed at b/287043578 Co-authored-by: Tong Mu <[email protected]>
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
## Description This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). This is a rework of #41695 which was reverted in #42346. This issue with #41695 was that the framework side did not get an answer when the channel was setup in the engine without registering a handler (on the engine side) to handle framework requests. The issue was reproducible when the engine initialization was managed by the app (see flutter/flutter#122441 (comment) for a repro). This PR fixes this issue by changing `flutter/keyboard` lifecycle: the engine now creates the channel and registers a handler just after the channel creation. In order to avoid regression, this PR also updates the channel implemenation (see `KeyboardChannel`) to return an empty `HashMap` when there is no handler registered. ## Related Issue Android engine implementation for flutter/flutter#87391 (see #42346 for Linux implementation) Fixes flutter/flutter#122441 ## Tests Adds 3 tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885).
Related Issue
Fixes flutter/flutter#122441
Android engine implementation for flutter/flutter#87391
Tests
Adds 2 tests.