This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Forward fix for roll of Dart SDK to version with new checked-in SDK #41634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checked-in SDK downloaded by Dart and engine checkouts from cipd has changed. The cipd package no longer includes dart-sdk at the start of all the paths of its files, so /dart-sdk is added to the path of the cipd download location. The script that automatically copies DEPS changes from the Dart SDK to engine does not handle the download location changing, and drops that entry. This change copies the changed download location and cipd reference from Dart SDK DEPS to engine. A roll of the Dart SDK to a version that does not include this update will fail by removing the changed line, so the next successful roll after this is landed must include Dart SDK commit 88aeaa4fec387ce6993b0bfe54d0d33c41d4554a. Link to this commit is https://dart.googlesource.com/sdk.git/+/88aeaa4fec387ce6993b0bfe54d0d33c41d4554a
Contributor
Author
|
I didn't realize that rebasing the PR started all the checks again - they already ran and finished on the first commit. |
Contributor
Author
|
Engine has now rolled to the last SDK dev version before this update, so this needs to land before the next roll will succeed. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 1, 2023
…125833) flutter/engine@687f4c7...58cc541 2023-05-01 [email protected] Roll Fuchsia Mac SDK from NBgD7NzOpwnAULR_g... to u7iIoiSX4y8WV6Of1... (flutter/engine#41641) 2023-05-01 [email protected] Add the verify exported symbols to linux builds. (flutter/engine#41635) 2023-05-01 [email protected] [Impeller] Turns on the Metal validator for impeller_unittests. (flutter/engine#40998) 2023-05-01 [email protected] [Impeller] Remove duplicate component in path.h (flutter/engine#41639) 2023-05-01 [email protected] Forward fix for roll of Dart SDK to version with new checked-in SDK (flutter/engine#41634) 2023-05-01 [email protected] Roll Skia from 1a6a1e905518 to 82d1ef7a833e (5 revisions) (flutter/engine#41637) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from NBgD7NzOpwnA to u7iIoiSX4y8W If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checked-in SDK downloaded by Dart and engine checkouts from cipd has changed.
The cipd package no longer includes dart-sdk at the start of all the paths of its files, so /dart-sdk is added to the path of the cipd download location.
The script that automatically copies DEPS changes from the Dart SDK to engine does not handle the download location changing, and drops that entry.
This change copies the changed download location and cipd reference from Dart SDK DEPS to engine. A roll of the Dart SDK to a version that does not include this update will fail by removing the changed line, so the next successful roll after this is landed must include Dart SDK commit 88aeaa4fec387ce6993b0bfe54d0d33c41d4554a.
Link to the Dart SDK commit is https://dart.googlesource.com/sdk.git/+/88aeaa4fec387ce6993b0bfe54d0d33c41d4554a