This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[codesign] Add pinned xcode version as property to mac android aot engine #41518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
reviewed
Apr 26, 2023
| "sdk_version": "14c18" | ||
| } | ||
| }, | ||
| "tests": [] |
godofredoc
reviewed
Apr 26, 2023
| "sdk_version": "14c18" | ||
| } | ||
| }, | ||
| "tests": [] |
Contributor
There was a problem hiding this comment.
Here and below rm the empty tests property
XilaiZhang
force-pushed
the
xilaizhang-android-2
branch
from
f1b997e to
cb27fab
Compare
godofredoc
approved these changes
Apr 26, 2023
Contributor
Author
|
As a side note, I was testing it with |
Contributor
Author
|
Sorry for the delay, was oncalling for flutter roll and there are roll bin breakages that needed attention, will merge now |
XilaiZhang
added
the
autosubmit
Contributor
|
Do we need to CP to beta release candidate branch? |
Contributor
Author
|
yup was about to do that but was in the midst of rolls, will do it now |
Contributor
Author
|
cp request at flutter/flutter#125591 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 27, 2023
XilaiZhang
added a commit
to XilaiZhang/engine
that referenced
this pull request
Apr 27, 2023
…gine (flutter#41518) context: flutter/flutter#125570 (comment) Pin xcode version for the six sub builds in mac android aot engine
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2023
…125593) flutter/engine@cf97541...d4ca524 2023-04-27 [email protected] Roll Skia from 20a1c61c5597 to d315ab065af3 (5 revisions) (flutter/engine#41535) 2023-04-26 [email protected] Revert "[Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend." (flutter/engine#41533) 2023-04-26 [email protected] [codesign] Add pinned xcode version as property to mac android aot engine (flutter/engine#41518) 2023-04-26 [email protected] [Impeller] Coerce opaque ColorSourceContents to Source (flutter/engine#41525) 2023-04-26 [email protected] Roll Skia from 3fea88565a83 to 20a1c61c5597 (3 revisions) (flutter/engine#41530) 2023-04-26 [email protected] [Impeller] partial repaint for Impeller/iOS. (flutter/engine#40959) 2023-04-26 [email protected] Updated todo with github issue link (flutter/engine#41517) 2023-04-26 [email protected] Roll Clang from 20d06c833d83 to 5344d8e10bb7 (flutter/engine#41524) 2023-04-26 [email protected] [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41374) 2023-04-26 [email protected] Manual clang roll to 5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520) 2023-04-26 [email protected] Download and use the goma client from cipd (flutter/engine#41488) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
itsjustkevin
pushed a commit
that referenced
this pull request
Apr 27, 2023
…1541) cherry picks #41518 cp issue link: flutter/flutter#125591 context: flutter/flutter#125570 (comment) Pin xcode version for the six sub builds in mac android aot engine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: flutter/flutter#125570 (comment)
Pin xcode version for the six sub builds in mac android aot engine