This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[impeller] convert src over to src for solid color" #41466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit be9185e.
Contributor
Author
|
This caused an unexpected regression. Reverting until we investigate the cause |
jason-simmons
approved these changes
Apr 25, 2023
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2023
…125452) flutter/engine@5fbde6c...8fe8e94 2023-04-25 [email protected] Revert "[impeller] convert src over to src for solid color" (flutter/engine#41466) 2023-04-24 [email protected] Remove empty tests properties. (flutter/engine#41461) 2023-04-24 [email protected] Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) (flutter/engine#41462) 2023-04-24 [email protected] Reland "Upload windows arm artifacts to production bucket." (flutter/engine#41409) 2023-04-24 [email protected] Roll Dart SDK from c7042dc03f43 to c3afc3507b4f (1 revision) (flutter/engine#41458) 2023-04-24 [email protected] Add 16.2 runtime to Mac unopt (flutter/engine#41456) 2023-04-24 [email protected] Roll Fuchsia Mac SDK from EEdHfWcEn3fHwQj46... to gxpKJcSBfY7AuR_Ur... (flutter/engine#41453) 2023-04-24 [email protected] Roll Fuchsia Linux SDK from fJ7ysM-O4VYAGeBDc... to 8TJtGsJTpIHk5-Ss5... (flutter/engine#41451) 2023-04-24 [email protected] Roll Dart SDK from a1c1e0d3bb18 to c7042dc03f43 (2 revisions) (flutter/engine#41452) 2023-04-24 [email protected] Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) (flutter/engine#41449) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from fJ7ysM-O4VYA to 8TJtGsJTpIHk fuchsia/sdk/core/mac-amd64 from EEdHfWcEn3fH to gxpKJcSBfY7A If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #41351