Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 24, 2023

@dnfield dnfield requested review from loic-sharma and zanderso April 24, 2023 17:28
@loic-sharma
Copy link
Member

Hm I don't think I've seen that error before, and I couldn't find an issue tracking that error. I'm not sure if it's a flake or a new issue from your roll. Let me know if you'd like me to try building your changes on my Windows machine.

dnfield added a commit to flutter/buildroot that referenced this pull request Apr 24, 2023
Needed for flutter/engine#41455

Our current VS Toolchain does not have the ARM64 artifacts in its
windows SDK.

This rolls to the latest one used in Chromium, with a link.
@dnfield
Copy link
Contributor Author

dnfield commented Apr 24, 2023

Needs https://flutter-review.googlesource.com/c/recipes/+/42462.

I'm trying to figure out why Linux Unopt sometimes gives LSAN/ASAN errors.

@dnfield
Copy link
Contributor Author

dnfield commented Apr 25, 2023

@bdero @zanderso fyi this rolls vulkan-deps past the hashes used in impeller-cmake.

@dnfield dnfield changed the title Roll ANGLE and vulkan-deps Roll vulkan-deps and vs_toolchain Apr 25, 2023
@dnfield
Copy link
Contributor Author

dnfield commented Apr 25, 2023

Rolling ANGLE to that revision is causing one of the embedder unittests to hang. I'm going to hold off on that for now and just do vulkan-deps/vs_toolchain

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 25, 2023

auto label is removed for flutter/engine, pr: 41455, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 25, 2023

auto label is removed for flutter/engine, pr: 41455, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 26, 2023

auto label is removed for flutter/engine, pr: 41455, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2023
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2023
@auto-submit auto-submit bot merged commit 706c023 into flutter:main Apr 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 26, 2023
@dnfield dnfield deleted the vulkan-deps branch April 28, 2023 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants