This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix SupportsReadFromOnscreenTexture capability check #41386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/capability-tests
branch
from
b7faaf4 to
b0abf01
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 21, 2023
…125302) flutter/engine@a7899c4...3f7e12b 2023-04-21 [email protected] Roll Skia from fbfed7c82918 to 5754b81988b8 (1 revision) (flutter/engine#41395) 2023-04-21 [email protected] Roll Dart SDK from 4cc2e637a315 to fabaeef00dfb (1 revision) (flutter/engine#41394) 2023-04-21 [email protected] Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... (flutter/engine#41393) 2023-04-21 [email protected] [Impeller] Fix SupportsReadFromOnscreenTexture capability check (flutter/engine#41386) 2023-04-21 [email protected] [Impeller] Always use BGRA10_XR for wide gamut (flutter/engine#41385) 2023-04-21 [email protected] Roll Skia from 90a93bb0990f to fbfed7c82918 (2 revisions) (flutter/engine#41392) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from PqBDstaESE_l to Edv0I0o8GQ7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we still weren't going down the blit-less path on iOS, and it turned out that the wrong capability was getting assigned in the builder.