This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Always use BGRA10_XR for wide gamut #41385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
force-pushed
the
bdero/wide-gamut-rootpass
branch
from
847a169 to
bbc9263
Compare
bdero
force-pushed
the
bdero/wide-gamut-rootpass
branch
from
bbc9263 to
4220180
Compare
Contributor
|
I've noticed the same validation errors on #40959 and confirmed that this PR fixes the problem. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 21, 2023
…125302) flutter/engine@a7899c4...3f7e12b 2023-04-21 [email protected] Roll Skia from fbfed7c82918 to 5754b81988b8 (1 revision) (flutter/engine#41395) 2023-04-21 [email protected] Roll Dart SDK from 4cc2e637a315 to fabaeef00dfb (1 revision) (flutter/engine#41394) 2023-04-21 [email protected] Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... (flutter/engine#41393) 2023-04-21 [email protected] [Impeller] Fix SupportsReadFromOnscreenTexture capability check (flutter/engine#41386) 2023-04-21 [email protected] [Impeller] Always use BGRA10_XR for wide gamut (flutter/engine#41385) 2023-04-21 [email protected] Roll Skia from 90a93bb0990f to fbfed7c82918 (2 revisions) (flutter/engine#41392) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from PqBDstaESE_l to Edv0I0o8GQ7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
May 15, 2023
Fixes errors blitting offscreen textures to onscreen textures when wide gamut is enabled due to the mismatching formats.
XilaiZhang
pushed a commit
that referenced
this pull request
May 15, 2023
cherry-pick for #41385 Co-authored-by: Brandon DeRosier <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens flutter/flutter#120641.
There are errors blitting from offscreen textures to onscreen textures when wide gamut is enabled due to the mismatching formats.
It looks like we don't currently use a different format when wide gamut is off either.