Update xcode to 14c18 #41370
Update xcode to 14c18 #41370
Conversation
|
Filed flutter/flutter#125216 for |
| "runtime_versions": [ | ||
| "ios-16-0_14a5294e" | ||
| ], |
There was a problem hiding this comment.
I believe the simulator runtimes need to be updated as well:
flutter/flutter#125216 (comment)
There was a problem hiding this comment.
Added and the CI is happy now.
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Temporarily blocking this, @zanderso has requested we hold off on this (and the inevitable slow down populating caches) until the very delayed engine -> framework roll gets unwedged. flutter/flutter#125221
This wouldn't directly impact the roll, but if there are changes needed in the engine to get it passing in the framework then engine build delays would slow it down.
@zanderso can you let us know when this is safe to land?
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Looks like the roll succeeded flutter/flutter#125271
LGTM!
keyonghan
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41370, due to This PR has not met approval requirements for merging. Changes were requested by {jmagman}, please make the needed changes and resubmit this PR.
|
Seems a bug with auto submit bot. created flutter/flutter#125280 to track. Manually submit here. |
…125290) flutter/engine@122c3b3...a7899c4 2023-04-21 [email protected] Roll Skia from 524ecb58945e to 90a93bb0990f (1 revision) (flutter/engine#41390) 2023-04-21 [email protected] Roll Fuchsia Mac SDK from 4OrPF9lzqCKGwBLRh... to fMOcI5zn1z0nOrV7s... (flutter/engine#41389) 2023-04-21 [email protected] Roll Skia from f4609aa2eaba to 524ecb58945e (23 revisions) (flutter/engine#41388) 2023-04-21 [email protected] Roll Dart SDK from 50b96abe9f6f to 4cc2e637a315 (1 revision) (flutter/engine#41387) 2023-04-21 [email protected] Update xcode to 14c18 (flutter/engine#41370) 2023-04-21 [email protected] Revert "[Impeller] Turned on wide gamut support by default." (flutter/engine#41382) 2023-04-21 [email protected] Revert "Manual roll skia to d5b4acfb4" (flutter/engine#41381) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 4OrPF9lzqCKG to fMOcI5zn1z0n If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
With https://flutter-review.googlesource.com/c/recipes/+/42160, we are ready to make all tests consistent with xcode 14c18.
Fixes flutter/flutter#125216