This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add ViewportMetricsUpdater to smooth out ViewportMetrics update signal #41295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cyanglaz I think this maybe better than others. Maybe you can take a look this too ^_^. Brief working principle: If currently UI task is not complete, the update metrics signal will be sent to the ui task queue's tail to ensure the update operation will be called after the vsync process callback. |
Contributor
Author
|
seems the viewport metrics update will depend on UI task... Some tests failed... Will try to fix this if this PR looks reasonable to land ^_^ |
Contributor
Author
|
Not sure why |
luckysmg
force-pushed
the
viewport_updater
branch
from
029d3e3 to
85d1bc6
Compare
Closed
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Triage
Will add test and modify comments and code if this patch looks reasonable.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.