This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web:canvaskit] clean up the rest of skia_object_cache usages #41259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
yjbanov
force-pushed
the
remove-skia-object-cache
branch
from
d6ec900 to
d2930d6
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 19, 2023
…125078) flutter/engine@5fcc7b7...099ed6c 2023-04-18 [email protected] Roll Fuchsia Mac SDK from qZHSvkpAU1-YYGvYc... to yD5a3QBJHUFM4nVou... (flutter/engine#41314) 2023-04-18 [email protected] [web:canvaskit] clean up the rest of skia_object_cache usages (flutter/engine#41259) 2023-04-18 [email protected] Roll Skia from f80ee1088861 to 476ee3fd54cc (2 revisions) (flutter/engine#41309) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from qZHSvkpAU1-Y to yD5a3QBJHUFM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should go after #41230.
Removes the remaining usages of
skia_object_cache.dartand deletes it.Also fixes flutter/flutter#86632