This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Migrate mac_host_engine to engine v2 builds." #41233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4ce42fe.
godofredoc
added
the
revert
fluttergithubbot
approved these changes
Apr 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2023
…124913) flutter/engine@c8d84cf...f6e64a8 2023-04-15 [email protected] Revert "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41233) 2023-04-15 [email protected] Roll Dart SDK from 5687f08b854d to afb0adeca5b6 (2 revisions) (flutter/engine#41232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
…lutter#124913) flutter/engine@c8d84cf...f6e64a8 2023-04-15 [email protected] Revert "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41233) 2023-04-15 [email protected] Roll Dart SDK from 5687f08b854d to afb0adeca5b6 (2 revisions) (flutter/engine#41232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
godofredoc
added a commit
that referenced
this pull request
Apr 17, 2023
This reverts commit f6e64a8.
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Reverts #41233 The issue this PR was reverted was not replicable. On top of that we added extra precautions to ensure global generators are using left over binaries from out folder. https://flutter-review.googlesource.com/c/recipes/+/41960
godofredoc
added a commit
that referenced
this pull request
Apr 19, 2023
This reverts commit f6e64a8.
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
) This reverts commit f6e64a8. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
zanderso
added a commit
that referenced
this pull request
Apr 20, 2023
godofredoc
added a commit
that referenced
this pull request
Apr 26, 2023
This reverts commit f6e64a8.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #41149